Add nanoseconds to stdout plugin #1249
Merged
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Fluentd supports nanosecond-resolution timestamps as of v0.14, it follows that the stdout output plugin should print the full timestamp. This is a very simple patch, instead of using the default `to_s` formatting, we call `strftime` with a custom formatting. Right now it always prints the nanoseconds, even on second-resolution timestamps. This means second-resolution timestamps will display like `2013-06-27 12:34:56.000000000 -0700`, which may be undesirable. If so, we can adjust the implement to print a condensed formatting for second-resolution timestamps.
|
This change looks reasonable, and good to me. |
|
LGTM. Changing out_stdout's result should not affect any production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Fluentd supports nanosecond-resolution timestamps as of v0.14,
it follows that the stdout output plugin should print the full
timestamp.
This is a very simple patch, instead of using the default
to_sformatting, we call
strftimewith a custom formatting.Right now it always prints the nanoseconds, even on second-resolution
timestamps. This means second-resolution timestamps will display like
2013-06-27 12:34:56.000000000 -0700, which may be undesirable. If so,we can adjust the implement to print a condensed formatting for
second-resolution timestamps.